Converted GenFilters to be edm::global modules [9_3 backport] #20910
Conversation
|
backport #20908 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_3_X. It involves the following packages: GeneratorInterface/GenFilters @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
| @@ -280,7 +280,7 @@ int MCParticlePairFilter::charge(const int& Id){ | |||
| int hepchg; | |||
|
|
|||
|
|
|||
| int ichg[109]={-1,2,-1,2,-1,2,-1,2,0,0,-3,0,-3,0,-3,0, | |||
| constexpr const int ichg[109]={-1,2,-1,2,-1,2,-1,2,0,0,-3,0,-3,0,-3,0, | |||
There was a problem hiding this comment.
@Dr15Jones for my education: isn't const redundant here?
|
merge |
No description provided.