Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix memory leak in creation of single leg conversions #2094

Merged
merged 1 commit into from Jan 24, 2014

Conversation

bendavid
Copy link
Contributor

Trivial fix for memory leak in recent EGamma code. No physics change expected.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_0_X.

fix memory leak in creation of single leg conversions

It involves the following packages:

RecoEgamma/EgammaPhotonProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Jan 21, 2014

@slava77 If you can get this in for 700 it would be useful. It's likely in part of the valgrind report you were going to send me. Obviously from the diffs there is no expected change in physics output.

@cmsbuild
Copy link
Contributor

@anton-a
Copy link

anton-a commented Jan 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

ktf added a commit that referenced this pull request Jan 24, 2014
Reco fix -- Fix memory leak in creation of single leg conversions
@ktf ktf merged commit ed85202 into cms-sw:CMSSW_7_0_X Jan 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants