New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.0.X] Few fixes and additions to SiStrip PI plugins #20946
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiStripPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
type bug-fix |
thanks @davidlange6 , I've implemented the suggestions |
+code-checks |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
merge |
[94X] Few fixes and additions to SiStrip PI plugins (backport of #20946)
Post-merge follow-up to #20643.
Fixed:
SiBadStrips
comparison plot due to not identicaldetIds
list size for first and last IOV.Added:
SiStripLorentzAngle
andSiStripBackplaneCorrection