Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0.X] Few fixes and additions to SiStrip PI plugins #20946

Merged
merged 8 commits into from Oct 29, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 17, 2017

Post-merge follow-up to #20643.

Fixed:

  • bug in the filling of the SiBadStrips comparison plot due to not identical detIds list size for first and last IOV.

Added:

  • 1D plot of payload dump values for SiStripLorentzAngle and SiStripBackplaneCorrection
  • Bad Strips Quality Statistics analysis breakout plot.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20946/1499

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23820/console Started: 2017/10/17 18:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20946/23820/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2793415
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793144
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Oct 25, 2017

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Oct 26, 2017

thanks @davidlange6 , I've implemented the suggestions

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20946/1653

@cmsbuild
Copy link
Contributor

Pull request #20946 was updated. @ggovi, @cmsbuild can you please check and sign again.

@mmusich mmusich changed the title [94X] Few fixes and additions to SiStrip PI plugins [10X] Few fixes and additions to SiStrip PI plugins Oct 26, 2017
@mmusich mmusich changed the title [10X] Few fixes and additions to SiStrip PI plugins [10.0.X] Few fixes and additions to SiStrip PI plugins Oct 26, 2017
@ggovi
Copy link
Contributor

ggovi commented Oct 27, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24007/console Started: 2017/10/27 10:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20946/24007/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2786851
  • DQMHistoTests: Total failures: 121
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2786559
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Oct 27, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 2380ae0 into cms-sw:master Oct 29, 2017
cmsbuild added a commit that referenced this pull request Nov 28, 2017
[94X]  Few fixes and additions to SiStrip PI plugins  (backport of #20946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants