Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StallMonitor handles case where module does not prefetch #20964

Merged

Conversation

Dr15Jones
Copy link
Contributor

The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.

The PathStatusInserter framework modules do not prefetch data (since they do not need it) and therefore the signal about prefetching is never set. This caused StallMonitor to incorrectly assign large stall times to these modules.
@Dr15Jones
Copy link
Contributor Author

There has been a request to have StallMonitor in all production jobs. This change will avoid having the StallMonitor give bogus results for the PathStatus generators.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_3_X.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23859/console Started: 2017/10/18 19:25

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_9_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

backport #20678

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20964/23859/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2708283
  • DQMHistoTests: Total failures: 229
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2707867
  • DQMHistoTests: Total skipped: 187
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4a685b3 into cms-sw:CMSSW_9_3_X Oct 25, 2017
@Dr15Jones Dr15Jones deleted the fixStallMonitorForPathStatus_9_3 branch March 22, 2018 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants