Dedicated timing plots for L1T objects - Online DQM & L1T - CMSSW_9_4_X #20969
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20969/1539 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-20969/1539/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @dtsitson for master. It involves the following packages: DQM/L1TMonitor @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
ghost
mentioned this pull request
DQM/L1TMonitor/src/L1TStage2uGT.cc
Outdated
|
|
||
| for(auto itr = uGtAlgs->begin(0); itr != uGtAlgs->end(0); ++itr) { |
There was a problem hiding this comment.
Hi @dtsitson ,
please add some proper indentation to this code and use spaces instead of tabulators.
|
The algo numbers for FirstBunchInTrain and LastBunchInTrain have changed in the v4 L1 menu and need to be updated. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #20969 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
|
+1 |
My task in JIRA is : ((https://its.cern.ch/jira/browse/CMSLITDPG-165))
First of all, I needed to make some changes in the code DQM/L1TMonitor/src/L1TStage2uGT.cc . (Of course, in the path : DQM/L1TMonitor/interface/L1TStage2uGT.h, we simply add the new histograms) These changes are mentioned to add some extra plots according to specific L1 Trigger bits (L1_FirstCollisionInTrain and L1_LastCollisionInTrain). So, after I initialize three plots, I used the last two trigger bits, as I mentioned, to fill them. The first plot which called first_bunch, selecting only the L1_FirstCollisionInTrain, is filled with all the algorithm trigger bits (y-axis) and BX (x-axis), the second plot which called last_bunch, selecting only the L1_LastCollisionInTrain, is filled with all the algorithm trigger bits (y-axis) and BX (x-axis), and the last plot called isolated_bunch is filled selecting simultaneously L1_FirstCollisionInTrain and L1_LastCollisionInTrain, is filled with all the algorithm trigger bits (y-axis) and BX (x-axis).