Run2-hcx159 Correct bug affecting several special cases for getPosition and getClosestCell

[bsunanda]

It affects Plan1 geometry as well as BH geometry for specific ieta values

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20976/1560

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalTowerAlgo

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23887/console Started: 2017/10/19 22:03

[cmsbuild]

+1
Tested at: 6c7804a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20976/23887/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e2f528f
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20976/23887/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20976/23887/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20976/23887/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 180 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2795245
• DQMHistoTests: Total failures: 415
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2794659
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• Checked 107 log files, 10 edm output root files, 26 DQM output files

[abdoulline]

50k single-pion MC test (with current 2017 = "Plan1" HCAL) shows no any difference w/wo this PR -

https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/94X_PR20976_vs_94X_SinglePi/

Plot "RecHits hE (GeV) vs ieta R = 0.3 Cone" explicitly involves "getPosition" in question.

[bsunanda]

@ianna @civanch Can you approve this PR?

[ianna]

@slava77 - FYI:

• Reco comparison results: 180 differences found in the comparisons

[ianna]

@bsunanda and @abdoulline - I wonder why nearly half of TrackingParticle tests report failure?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_4_X_2017-10-19-1100+20976/23215/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/PixelPhase1V.html

[bsunanda]

@ianna I cannot say about TrackingParticles but without these changes the geometry tests for HCAL fails. So please approve this

[ianna]

+1

Note: reco comparison differences need to be understood

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

@ianna - the pixel 2017 comparisons differ due to buggy dqm code (that apparently is already not supported)

otherwise, it looks like the differences are only seen in 2019 workflows (eg, after LS2 barrel upgrade)

[davidlange6]

+1