Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add/correct BuildFile.xml #20989

Merged

Conversation

depasse
Copy link
Contributor

@depasse depasse commented Oct 23, 2017

Previous version EcalPayloadInspector_with_PlotImage_v3 : to avoid Clang error : "Better to remove BuildFile.xml ", so removed it but does not work

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20989/1597

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondCore/EcalPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@smuzaffar smuzaffar modified the milestones: CMSSW_9_4_X, CMSSW_10_0_X Oct 26, 2017
@cmsbuild cmsbuild modified the milestones: CMSSW_10_0_X, CMSSW_9_4_X Oct 26, 2017
@ggovi
Copy link
Contributor

ggovi commented Nov 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24105/console Started: 2017/11/01 16:09

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20989/24105/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 118
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838153
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20989/1913

@cmsbuild
Copy link
Contributor

Pull request #20989 was updated. @ggovi, @cmsbuild can you please check and sign again.

@ggovi
Copy link
Contributor

ggovi commented Nov 13, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24391/console Started: 2017/11/13 09:56

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20989/24391/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2771567
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2771388
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.529999999977 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Nov 14, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 45cd82f into cms-sw:master Nov 14, 2017
@depasse depasse deleted the EcalPayloadInspector_with_PlotImage_v4 branch February 14, 2018 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants