Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add originalXWGTUP() to LHEEvent and LHEEventProduct 53X edition #2100

Merged
merged 1 commit into from
Jan 30, 2014

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Jan 21, 2014

Rebase of #2097 to CMSSW 53X

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_5_3_X.

add originalXWGTUP() to LHEEvent and LHEEventProduct 53X edition

It involves the following packages:

GeneratorInterface/LHEInterface
SimDataFormats/GeneratorProducts

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@lgray
Copy link
Contributor Author

lgray commented Jan 27, 2014

@ktf this is missing only tests and ORP signing, can you please tell jenkins to take care of this one?
@davidlange6 +1 after tests, please?

@ktf
Copy link
Contributor

ktf commented Jan 27, 2014

@lgray, we currently do not have a jenkins rule for 53X, this is getting tested by hand.
@nclopezo can you try to see if you can copy and adapt the 71X test job to 53X? Thanks.

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Jan 30, 2014
add originalXWGTUP() to LHEEvent and LHEEventProduct 53X edition
@smuzaffar smuzaffar merged commit 0b56b8a into cms-sw:CMSSW_5_3_X Jan 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants