New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for conddb dump command #21038
Fix for conddb dump command #21038
Conversation
The code-checks are being triggered in jenkins. |
please test |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ggovi for master. It involves the following packages: CondCore/Utilities @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
merge |
@@ -143,7 +143,7 @@ def prepPayload2xml(self, payloadType): | |||
codeFile.write(code) | |||
codeFile.close() | |||
|
|||
cmd = "source /afs/cern.ch/cms/cmsset_default.sh;" | |||
cmd = "source /cvmfs/cms.cern.ch/cmsset_default.sh;" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work if person is not using sh-compatible shell?
Why don't you use $CMS_PATH/cmsset_default.{sh,csh}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidlt It's a good suggestion for the $CMS_PATH. For the shell type, is this required, considering that the command will be executed by python?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, required. I looked again at documentation and only now noticed:
On Unix with shell=True, the shell defaults to /bin/sh.
So it's bash/dash/zsh/whatever-sh-compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I'm preparing a new PR...
Fix for checkouts on cluster outside CERN: setup file sourced from afs is changed to cvmfs