Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoided uneeded run and luminosity block calls #21063

Merged
merged 5 commits into from Oct 29, 2017

Conversation

Dr15Jones
Copy link
Contributor

We determine if a particular module actually needs to be called for a given global or stream transition. If it does not need to be called, then we no longer make the call.

Can ask a module if it needs access to the global Run and LuminosityBlock transitions.
Use the information about if a module actually wants to be called for a global transition to decide if we should run the module.
Only if a module needs to see a particular stream transition will it be run for that transition.
Now the worker decides if the module should be run for global transitions as well as stream transitions.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21063/1694

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24033/console Started: 2017/10/28 23:25

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21063/24033/summary.html

There are some workflows for which there are errors in the baseline:
10042.0 step 5
10024.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 217 differences found in the comparisons
  • DQMHistoTests: Total files compared: 24
  • DQMHistoTests: Total histograms compared: 2405189
  • DQMHistoTests: Total failures: 205
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2404827
  • DQMHistoTests: Total skipped: 157
  • DQMHistoTests: Total Missing objects: 0
  • Checked 97 log files, 10 edm output root files, 24 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e099e08 into cms-sw:master Oct 29, 2017
@Dr15Jones Dr15Jones deleted the avoidedUneededRunLumiCalls branch October 30, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants