New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoided uneeded run and luminosity block calls #21063
Conversation
Can ask a module if it needs access to the global Run and LuminosityBlock transitions.
Use the information about if a module actually wants to be called for a global transition to decide if we should run the module.
Only if a module needs to see a particular stream transition will it be run for that transition.
Now the worker decides if the module should be run for global transitions as well as stream transitions.
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
merge |
We determine if a particular module actually needs to be called for a given global or stream transition. If it does not need to be called, then we no longer make the call.