-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to save PS weights from Pythia8 (Backport of #21073) #21074
Fix to save PS weights from Pythia8 (Backport of #21073) #21074
Conversation
…n using Powheg. Backport of cms-sw#21073
A new Pull Request was created by @jfernan2 for CMSSW_9_3_X. It involves the following packages: GeneratorInterface/Pythia8Interface @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#3539 |
The tests are being triggered in jenkins. |
-1 Tested at: e976a50 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/TauolaInterface/src/TauolaInterfaceBase.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/Py8toJetInput.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/PowhegResHook.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/JetMatchingHook.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:27: fatal error: Vincia/Vincia.h: No such file or directory #include "Vincia/Vincia.h" ^ compilation terminated. /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_3_X_2017-10-30-1100/src/GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:14:27: fatal error: Vincia/Vincia.h: No such file or directory #include "Vincia/Vincia.h" The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
@jfernan2 according to @mkirsano you have some 94x code that is not yet backported to 93x (namely related to Vincia) which causes the test to fail |
@jfernan2 please make your changes on top of Pythia8Interface from 93X, not 94X |
Sorry my fault. Here it goes the right commit. |
please test with cms-sw/cmsdist#3539 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
merge |
Fix to save PS weights from Pythia8 in GenEventInfoProduct record When using Powheg.
Backport of #21073