Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup BuildFiles for ASAN and UBSAN #21077

Merged
merged 1 commit into from Oct 30, 2017
Merged

cleanup BuildFiles for ASAN and UBSAN #21077

merged 1 commit into from Oct 30, 2017

Conversation

smuzaffar
Copy link
Contributor

Cleaning up BuildFile flags for ASAN and UBSAN. New build rules has a support for these

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21077/1710

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24048/console Started: 2017/10/30 13:55

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

FWCore/Framework
FWCore/ParameterSet
FWCore/PluginManager

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 30, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24049/console Started: 2017/10/30 14:17

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21077/24049/summary.html

There are some workflows for which there are errors in the baseline:
10024.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2621497
  • DQMHistoTests: Total failures: 95
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2621238
  • DQMHistoTests: Total skipped: 164
  • DQMHistoTests: Total Missing objects: 0
  • Checked 102 log files, 10 edm output root files, 25 DQM output files

@smuzaffar
Copy link
Contributor Author

this is technical build change, so I am merging it to get it in next IB

@smuzaffar smuzaffar merged commit 5373d14 into cms-sw:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants