Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10x] trivial fix in the filling of fit charge MPV vs sensor thickness #21089

Merged
merged 2 commits into from Nov 2, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 31, 2017

Title says it all, the histograms are supposed to be 1D.
Attention @dimattia

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21089/1729

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @gbenelli, @tocheng, @jlagram, @OlivierBondu, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

ghellwig commented Nov 1, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24106/console Started: 2017/11/01 16:11

@ghellwig
Copy link

ghellwig commented Nov 1, 2017

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21089/24106/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 119
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838152
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21089/1761

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Pull request #21089 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@ghellwig
Copy link

ghellwig commented Nov 2, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24134/console Started: 2017/11/02 11:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21089/24134/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 120
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838151
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants