Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos in HLT validation directories #21092

Merged
merged 2 commits into from Nov 3, 2017

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Oct 31, 2017

by mistake (they were typos)
few DQM directories under HLT were misspelled

this PR fixes the following
HLT/EG/Tracking --> HLT/EGM/Tracking
HLT/RecHits --> HLT/HCAL/RecHits

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mtosi
Copy link
Contributor Author

mtosi commented Oct 31, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21092/1731

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24080/console Started: 2017/10/31 14:00

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

DQM/HLTEvF
HLTriggerOffline/Egamma
Validation/HcalRecHits

@cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @Martin-Grunewald, @silviodonato, @fwyzard, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

Are these typos a sin of monitoring that is not used much (since February in the one case I checked)?

@mtosi
Copy link
Contributor Author

mtosi commented Oct 31, 2017 via email

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21092/24080/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2833642
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2833361
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

hi @mtosi - i don't understand your comment? Is this a typo fix or just a renaming to make things consistent?

@mtosi
Copy link
Contributor Author

mtosi commented Nov 2, 2017 via email

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0a2d039 into cms-sw:master Nov 3, 2017
cmsbuild added a commit that referenced this pull request Nov 21, 2017
fix typos in HLT validation directories (#21092 backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants