Modules will see end transition if they saw a begin transition #21108
Conversation
If we call a begin Run or begin LuminosityBlock transition we need to call the corresponding end transition. If a global begin transition fails, we skip the corresponding begin/end stream transitions. We only call writeRun or writeLumi if the full transition succeeds.
Even if the parent process throws an exception during a Run or LuminosityBlock transition, we still run the transition for the SubProcess. This helps guarantee that if a module gets a begin transition call it will also receive an end transition call.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
merge |
In the case where an exception occurs during a begin Run/LuminosityBlock transition we make sure that modules which saw that transition will also see the related end transition. This is accomplished by requiring all modules to see a transition once that transition has started. In this way we do not have to record which modules have seen which transitions (since it will be all or none).
If the exception happened during the global part of the transition, we do not then run the stream part of the transition in order to attempt to minimize the time to end the application.