Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.4.X] Fix arrow plots in geometry comparison tool #21160

Merged
merged 8 commits into from Nov 19, 2017

Conversation

ghellwig
Copy link

@ghellwig ghellwig commented Nov 3, 2017

backport of #21159

Main focus is on resurrecting arrow plots.
Few minor fixes/changes:

  • remove remaining usage of 'eos' command
  • change default to produce only global plots which contain already all information
    • saves disk space
  • allow special characters in alignment names

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_9_4_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link
Author

ghellwig commented Nov 3, 2017

type bugfix

@ghellwig
Copy link
Author

ghellwig commented Nov 3, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24169/console Started: 2017/11/03 21:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21160/24169/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838168
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@arunhep
Copy link
Contributor

arunhep commented Nov 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 51ebec9 into cms-sw:CMSSW_9_4_X Nov 19, 2017
@ghellwig ghellwig deleted the fix-arrow-plots_94X branch December 19, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants