Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in DQMGenericClient #21181

Merged
merged 1 commit into from Nov 7, 2017
Merged

Conversation

dmitrijus
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21181/1835

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

A new Pull Request was created by @dmitrijus (Dmitrijus) for master.

It involves the following packages:

DQMServices/ClientConfig

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @barvic this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@dmitrijus
Copy link
Contributor Author

please test workflow 10024.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24200/console Started: 2017/11/06 15:15

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21181/24200/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2900266
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2900094
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Nov 7, 2017

@dmitrijus
Can you please make a backport also for 92X? Recent relvals for HLT in 9_2_14 were affected by the harvesting failure as well

@dmitrijus
Copy link
Contributor Author

+1

@dmitrijus
Copy link
Contributor Author

I will, I was just waiting for the tests to finish.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0b05d46 into cms-sw:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants