DeepCSV/DeepCMVA discriminators

[mverzett]

verbatim backport of #20940

[cmsbuild]

A new Pull Request was created by @mverzett (Mauro Verzetti) for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/Combined

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[slava77]

@mverzett
please provide some justifications to include this in miniAOD.
This is a new feature that changes the production miniAOD output and 94X is closed for new features.
An exception request is needed from PC, to be confirmed then with PPD and S&C.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24277/console Started: 2017/11/08 18:42

[cmsbuild]

+1
Tested at: 6213e94
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21215/24277/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3e73eef
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21215/24277/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21215/24277/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21215/24277/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2879519
• DQMHistoTests: Total failures: 105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2879243
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
• Checked 107 log files, 8 edm output root files, 26 DQM output files

[perrotta]

+1

• Identical to DeepCSV/DeepCMVA discriminators #20940, merged in the master
• DeepCSV/DeepCMVA discriminators added to miniAOD as simple arithmetic over the input probabilities
• That addition to the event is only in miniAOD, and does not propagates to other objects in the miniAOD event content

[perrotta]

Please @mverzett inquire with PC/PPD for the inclusion in a supposedly closed release, as already requested in #21215 (comment), and report here about it

Please @davidlange6 consider for merging in 94X as soon as that confirmation is obtained

[ghost]

Thanks @perrotta , we have sent a mail with you in CC

[ghost]

Dear all,

we have received the blessing from PPD. So, if possible, it would be nice to have this in 94X.
Thanks to all,

Ivan

[perrotta]

Thank you @imarches

@davidlange6 : are we still in time to include this in 94X? Thank you!

[davidlange6]

merge