Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PhysicsTools & Validation pkgs comp warnings after clang-tidy #21218

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Nov 8, 2017

Fix comp warnings listed here:
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc630/www/tue/10.0-tue-11/CMSSW_10_0_X_2017-11-07-1100
in PhysicsTools/* and Validation/RecoParticleFlow

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21218/1873

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

A new Pull Request was created by @mrodozov for master.

It involves the following packages:

PhysicsTools/ParallelAnalysis
PhysicsTools/RooStatsCms
PhysicsTools/TagAndProbe
Validation/RecoParticleFlow

@vazzolini, @kmaeshima, @monttj, @cmsbuild, @jfernan2, @vanbesien, @dmitrijus can you please review it and eventually sign? Thanks.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Nov 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24280/console Started: 2017/11/08 19:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21218/24280/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21218/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2967244
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2967065
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 5ebfbed into cms-sw:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants