Remove unused vars in multiple pkgs #21221
Conversation
|
The code-checks are being triggered in jenkins. |
|
please test |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mrodozov for master. It involves the following packages: L1Trigger/L1TCalorimeter @civanch, @Dr15Jones, @vazzolini, @kmaeshima, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @monttj, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -166,8 +166,6 @@ double LumiReWeighting::weight( const edm::EventBase &e ) { | |||
|
|
|||
| for(; PHist_iter<PHist.end() ;++PHist_iter) { | |||
| edm::ProcessConfiguration PConf = *(PHist_iter); | |||
| const edm::ReleaseVersion& Release = PConf.releaseVersion() ; | |||
There was a problem hiding this comment.
@mdhildreth - please, have a look. Thanks.
There was a problem hiding this comment.
indeed, these loops appear to make no sense..
There was a problem hiding this comment.
With this change PConf is now an unused variable.
I checked, and non of the functions called in this loop have side-effects, so there is no useful work being done.
On the other hand, the call to e.processHistory() can throw if there is a problem.
There was a problem hiding this comment.
I'm updating the PR then
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
| @@ -166,8 +166,6 @@ double LumiReWeighting::weight( const edm::EventBase &e ) { | |||
|
|
|||
| for(; PHist_iter<PHist.end() ;++PHist_iter) { | |||
| edm::ProcessConfiguration PConf = *(PHist_iter); | |||
| const edm::ReleaseVersion& Release = PConf.releaseVersion() ; | |||
There was a problem hiding this comment.
With this change PConf is now an unused variable.
I checked, and non of the functions called in this loop have side-effects, so there is no useful work being done.
On the other hand, the call to e.processHistory() can throw if there is a problem.
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
cmsbuild
added
code-checks-pending
comparison-pending
tests-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Pull request #21221 was updated. @civanch, @Dr15Jones, @vazzolini, @kmaeshima, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @monttj, @mulhearn can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
merge |
Remove unused vars from three packages. Note that the changes here:
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/Utilities/src/LumiReWeighting.cc#L169
and here
https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/Utilities/src/LumiReWeighting.cc#L221
are leaving the for loops without obvious purpose (from a glance) yet there was no comp warning for PConf being unused (not sure why), so I'll leave them (the loops) as they are.