Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxtracks parameter for offline validation #21224

Merged
merged 3 commits into from
Nov 21, 2017

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Nov 8, 2017

backport of #21223

So that the validation can stop after a specified number of tracks, rather than just a number of events. Because the DMR plots count the number of modules per bin, rather than the number of tracks per bin, the number of tracks has to be the same when comparing two geometries.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_9_4_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@hroskes hroskes force-pushed the maxtracks-offline-validation branch from 3287821 to cbb0eb0 Compare November 8, 2017 20:40
@arunhep
Copy link
Contributor

arunhep commented Nov 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24292/console Started: 2017/11/09 08:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21224/24292/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2914206
  • DQMHistoTests: Total failures: 103
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2913932
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 22 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Pull request #21224 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #21224 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@ghellwig
Copy link

please test

@ghellwig
Copy link

+1
provided jenkins agrees

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24349/console Started: 2017/11/10 16:39

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21224/24349/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 113
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2779377
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e7fb58a into cms-sw:CMSSW_9_4_X Nov 21, 2017
@hroskes hroskes deleted the maxtracks-offline-validation branch October 29, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants