Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete references to the online "connection string" #21226

Merged
merged 1 commit into from Nov 11, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Nov 8, 2017

Running cmsRun at Point 5 within the .cms network used to require a dedicated
connection string, of the form
frontier://(proxyurl=http://localhost:3128)(serverurl=http://localhost:8000/FrontierOnProd)(serverurl=http://localhost:8000/FrontierOnProd)(retrieve-ziplevel=0)(failovertoserver=no)/CMS_CONDITIONS

This is no longer necessary since

  • the frontier services at P5 now use the standard name 'FrontierProd' rather than 'FrontierOnProd'
  • the proxy and server settings are stored in the SITECONF

Running cmsRun at Point 5 within the .cms network used to require a dedicated
connection string, of the form
'frontier://(proxyurl=http://localhost:3128)(serverurl=http://localhost:8000/FrontierOnProd)(serverurl=http://localhost:8000/FrontierOnProd)(retrieve-ziplevel=0)(failovertoserver=no)/CMS_CONDITIONS'

This is no longer necessary since
  - the frontier services at P5 now use the standard name 'FrontierProd' rather than 'FroontierOnProd'
  - the proxy and server settings are stored in the SITECONF
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Nov 8, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21226/1878

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24286/console Started: 2017/11/08 21:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
CondTools/Ecal
CondTools/L1Trigger
DQM/BeamMonitor
DQM/CSCMonitorModule
DQM/DTMonitorModule
DQM/DataScouting
DQM/EcalCommon
DQM/Integration
DQM/TrigXMonitor
DQM/TrigXMonitorClient
L1Trigger/CSCTriggerPrimitives
L1TriggerConfig/CSCTFConfigProducers
RecoTauTag/Configuration

@perrotta, @ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @rekovic, @franzoni, @jfernan2, @slava77, @ggovi, @vanbesien, @mulhearn, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @valuev, @barvic, @batinkov, @makortel, @mtosi, @tocheng, @argiro, @Martin-Grunewald, @thomreis, @ptcox, @mmusich, @threus, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21226/24286/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21226/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2967244
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2967065
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram bins added: 0.0 ( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 9, 2017

+1

for #21226 a550665

  • reco is affected only in RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py
  • jenkins tests pass and comparisons show no differences

@ghellwig
Copy link

+1

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 64a7b6b into cms-sw:master Nov 11, 2017
@fwyzard fwyzard deleted the update_connection_string branch November 23, 2017 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants