add TracksFilter.cc #21241
add TracksFilter.cc #21241
Conversation
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21241/1904 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/PR-21241/1904/git-diff.patch You can run |
|
The code-checks are being triggered in jenkins. |
|
@cmsbuild, please test |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: HLTrigger/special @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Thanks @makortel , this actually works:
#include "CommonTools/UtilAlgos/interface/ObjectCountFilter.h"
#include "CommonTools/UtilAlgos/interface/StringCutObjectSelector.h"
#include "DataFormats/TrackReco/interface/Track.h"
#include "DataFormats/TrackReco/interface/TrackFwd.h"
using TrackSelectorCountFilter = ObjectCountFilter<reco::TrackCollection, StringCutObjectSelector<reco::Track, false>>::type;
// declare this template instantiation as a framework plugin
#include "FWCore/Framework/interface/MakerMacros.h"
DEFINE_FWK_MODULE(TrackSelectorCountFilter);However it has a big problem: this does not implement the module's Also, why do we have two files called |
Since we've hit this wall already before, I decided to try to craft a prototype of fillDescriptions for the generic selector infrastructure, and ended up with #21430. With that PR and the |
|
On 11/22/17 5:28 AM, Matti Kortelainen wrote:
However it has a big problem: this does not implement the module's
fillDescriptions method, and so no cfi file is generated; meaning
that this filter will not be available for use at HLT - which was
the whole point.
Since we've hit this wall already before, I decided to try to craft a
prototype of fillDescriptions for the generic selector infrastructure,
and ended up with #21430 <#21430>.
With that PR and the |FillDescriptionTraits| shown in the PR description
placed after |using TrackSelectorCountFilter = ...| in @fwyzard
<https://github.com/fwyzard>'s code snippet from #21241 (comment)
<#21241 (comment)>, a
cfi file is generated.
It should still be possible to implement the fillDescriptions for the
module as a part of full template specialization on top of what the
template brings by default, shouldn't it?
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21241 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbsn1exLwFDYaTPNoc88X-wmaVxg5ks5s5CF9gaJpZM4QYPJJ>.
|
I'm not sure I follow. I agree that by specializing class templates one can, in general, do whatever. Which (class?) template are you talking about? (should we move the discussion to #21430?) |
But that would defeat the purpose of using the template approach in the first place, no ? |
|
On 11/22/17 6:15 AM, Andrea Bocci wrote:
It should still be possible to implement the fillDescriptions for the
module as a part of full template specialization on top of what the
template brings by default, shouldn't it?
But that would defeat the purpose of using the template approach in the
first place, no ?
It does not defeat the purpose of implementing run time functionality.
The PSet validation may even be better off in an extra function because
the template
argument tool multiplexing may not allow for the most efficient
documentation representation or for default settings that match a
specific mix of the template arguments.
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21241 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcbinBaQTItwGXAUKW14oshgEvxiGZks5s5CyKgaJpZM4QYPJJ>.
|
|
On 11/23/17 1:49 AM, Matti Kortelainen wrote:
@slava77 <https://github.com/slava77> Is #21443
<#21443> along what you had in mind?
I have responded there
I was thinking of smth like
master...slava77:CMSSW_10_0_0_pre1/evSelector-fillDescSpec-example
…
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21241 (comment)>, or
mute the thread
<https://github.com/notifications/unsubscribe-auth/AEdcblfKKjYIo_3Gy0i9Uxv5e4UlUdpwks5s5T_GgaJpZM4QYPJJ>.
|
|
This is just to notify here that #21430 was just merged in 10_0_X, so that every one interested in pushing forward this pull request can take profit of it |
|
-1
|
|
@mtosi is this PR still needed and is there any activity planned in the short term? Otherwise better to close it and resume when some work can be put on it |
|
thanks for the ping, and sorry for this never ending PR |
EDFilter to be used in the cosmics during collision (CDC) trigger @HLT
as far as I know, indeed, there are not available such event filters
this makes use of the logical expression used by many selectors for selecting the tracks
and then it requests a minimum number of such tracks