New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include PSet which is referenced via refToPSet_ #21268
Include PSet which is referenced via refToPSet_ #21268
Conversation
In order to help avoid the case where the PSet CkfBaseTrajectoryFilter_block is added to a module configuration via a refToPSet_ but is not itself added to the Process we now import that PSet into the cfi files which reference it. The missing reference error happened when the fastsim configuration was changed to more fully utilize eras. This broke the configurations used to generate pileup for fastsim (since only part of the RECO sequence is used).
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTracker/CkfPattern @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 135.8, 250399.0 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
In order to help avoid the case where the PSet CkfBaseTrajectoryFilter_block
is added to a module configuration via a refToPSet_ but is not itself
added to the Process we now import that PSet into the cfi files
which reference it.
The missing reference error happened when the fastsim configuration
was changed to more fully utilize eras. This broke the configurations
used to generate pileup for fastsim (since only part of the RECO
sequence is used).