Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include PSet which is referenced via refToPSet_ #21268

Merged

Conversation

Dr15Jones
Copy link
Contributor

In order to help avoid the case where the PSet CkfBaseTrajectoryFilter_block
is added to a module configuration via a refToPSet_ but is not itself
added to the Process we now import that PSet into the cfi files
which reference it.
The missing reference error happened when the fastsim configuration
was changed to more fully utilize eras. This broke the configurations
used to generate pileup for fastsim (since only part of the RECO
sequence is used).

In order to help avoid the case where the PSet CkfBaseTrajectoryFilter_block
is added to a module configuration via a refToPSet_ but is not itself
added to the Process we now import that PSet into the cfi files
which reference it.
The missing reference error happened when the fastsim configuration
was changed to more fully utilize eras. This broke the configurations
used to generate pileup for fastsim (since only part of the RECO
sequence is used).
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21268/1943

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoTracker/CkfPattern
RecoTracker/IterativeTracking

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test workflow 135.8, 250399.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24365/console Started: 2017/11/10 19:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21268/24365/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2832699
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2832520
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.11000000004 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2017

+1

for #21268 1d9bb21

  • fix fastsim premixing
  • jenkins tests pass and there are no differences in regular workflows and the additional FS premix workflows tested run to completion

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3bd47db into cms-sw:master Nov 13, 2017
@Dr15Jones Dr15Jones deleted the fixBrokenRefToPSetLinkageForFastSim branch November 15, 2017 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants