Fix MultiTrackValidator seeding layers configuration for FastSim

[makortel]

PR #20884 that changed FastSim reconstruction era based broke the seeding layers configuration logic in Validation/RecoTrack/python/TrackValidation_cff.py. This PR patches the logic to explicitly handle the FastSim-specific seed producer.

More details (copied from #20879 (comment))

The affected code is here

cmssw/Validation/RecoTrack/python/TrackValidation_cff.py

Lines 194 to 202 in 62cb420

	seedingLayersMerged = []
	for seedName in seedProducers:
	seedProd = getattr(config, seedName)
	if hasattr(seedProd, "OrderedHitsFactoryPSet"):
	seedingLayersName = seedProd.OrderedHitsFactoryPSet.SeedingLayers.getModuleLabel()
	elif hasattr(seedProd, "seedingHitSets"):
	seedingLayersName = _findSeedingLayers(seedProd.seedingHitSets.getModuleLabel())
	else:
	continue

Now the <iteration name>Seeds module in iterativeTk_cff.py is changed with fastsim modifier and therefore both of the if branches fail leading to continue. Except for initialStepPreSplitting and jetCoreRegionalStep which are not used in FastSim and the seeding module is not replaced (and therefore the code above is able to extract layer lists from there).

Tested in CMSSW_10_0_X_2017-11-09-2300, expecting more seeding layers in the MTV histograms vs. seeding layers in FastSim workflows.

@akapoorcern @angirar @slava77 @Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

Thanks!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21276/1950

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Validation/RecoTrack

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @wmtford, @ebrondol, @mtosi, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24372/console Started: 2017/11/10 21:55

[cmsbuild]

+1
Tested at: 1072c0f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21276/24372/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
62cb420
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21276/24372/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21276/24372/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21276/24372/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832699
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 238
• DQMHistoTests: Total successes: 2832282
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.04000000007 KiB( 22 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1