add PU=0 at the start of vectors (94x)

[capalmer85]

No description provided.

[cmsbuild]

A new Pull Request was created by @capalmer85 for CMSSW_9_4_X.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[franzoni]

@capalmer85
by adding a 0 also in front of probValue
you're shifting the distribution of PU up by one unit.

Is such shift consistent with the plots I refer to here https://hypernews.cern.ch/HyperNews/CMS/get/prep-ops/4550/2/2/1/1/1/1.html
?

[cmsbuild]

Pull request #21285 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[capalmer85]

@franzoni, you were right. I compared with my histogram. The PU vector was off by 1 in the original. This should be fixed now.

[franzoni]

ok - this PR does, in the substance, the same as used by @GurpreetSinghChahal in the submission explained here
https://hypernews.cern.ch/HyperNews/CMS/get/prep-ops/4550/2/2/1/1/1.html

thanks!

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24416/console Started: 2017/11/14 11:53

[cmsbuild]

+1
Tested at: f9806c0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21285/24416/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
df93725
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21285/24416/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21285/24416/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21285/24416/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2779661
• DQMHistoTests: Total failures: 105
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2779385
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 107 log files, 8 edm output root files, 26 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

merge