keep islandPhoton related collections via HI eras

[ttrk]

stores PhotonCore and corrected SuperCluster collections corresponding to islandPhotons.
This PR is for HI-related eras, in particular pp_on_XeXe_2017, ppRef_2017.
These collections are necessary for SC information and their addition was omitted in the previous PR #21122

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21310/1999

[cmsbuild]

A new Pull Request was created by @ttrk (Kaya Tatar) for master.

It involves the following packages:

RecoEcal/Configuration
RecoEgamma/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @rovere, @argiro, @lgray, @varuns23 this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24440/console Started: 2017/11/15 08:32

[perrotta]

abort test

[cmsbuild]

Jenkins tests are aborted.

[perrotta]

please test workflow 149.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24442/console Started: 2017/11/15 08:37

[cmsbuild]

+1
Tested at: 9c8ab70
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21310/24442/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6a9e6e4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21310/24442/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21310/24442/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21310/24442/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832924
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832745
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.06999999994 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[perrotta]

(INFO) This pull request adds the following event content and sizes, as measured on 20 evts from wf 149 QCD_Pt_80_120 for ppref:

• recoSuperClusters_correctedIslandEndcapSuperClusters__RECO. 1662.2 513.65
• recoSuperClusters_correctedIslandBarrelSuperClusters__RECO. 1632.6 496.9
• recoPhotonCores_islandPhotonCore__RECO. 365.95 132.25

As a comparison, the sizes of the other "island" relared products in the same wf is:

• recoCaloClusters_islandBasicClusters_islandEndcapBasicClusters_RECO. 3184.05 1002.45
• recoCaloClusters_islandBasicClusters_islandBarrelBasicClusters_RECO. 1748.55 620.25
• recoPhotons_islandPhotons__RECO. 1063.05 474.1
• recoHIPhotonIsolationedmValueMap_photonIsolationHIProducerppIsland__RECO. 272.15 222.55

[perrotta]

@ttrk : could you please modify the description of this PR (if not the title) making clear that this additional event content refers to HI ppref?
(The same for its sibling in 94X)

[perrotta]

+1

• Addition of a few missing EGamma products in the RECO/AOD event contents

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[ttrk]

@perrotta Ideally this PR should have been in 92X as well, though no production with that release is projected. Do you want a backport to 92X?

[perrotta]

@ttrk : the 5 TeV run is expected to end on Wednesday morning. It you really want it for the last few days of data taking you can prepare the backport PR and ask the release managers for a patch release. Technically, I have no idea how quick it could be setting up, testing and deploying it: since you only add a few products without changing anything it could probably be fast...
Otherweise, just wait for the reprocessing with 94X

[davidlange6]

+1

[ttrk]

@perrotta : This PR was urgent for xexe re-reco. For 5 TeV pp ref, it is not urgent for prompt reco and can wait for its re-reco.