Fix GenParticles2HepMCConverter to run on herwig samples #21349

jhgoh · 2017-11-17T13:22:23Z

The GenParticles2HepMCConverter was written assuming the first two particles in the event record are incident protons. This is is not true for Herwig samples and can introduce crash while invoking RivetAnalysis in the ParticleLevelProducer.

For an example, GenParticles list from a 80X TTbar herwig sample appears like below:

[ParticleListDrawer] analysing particle collection prunedGenParticles
 idx  |    ID -       Name |Stat|  Mo1  Mo2  Da1  Da2 |nMo nDa|    pt       eta     phi   |     px         py         pz        m     |
    0 |     6 -          t | 11 |   42   59   15   15 |  2  1 | 103.091     -2.071 -2.243 |    -64.186    -80.671   -402.211  171.651 |
    1 |    -6 -       tbar | 11 |   42   59   16   16 |  2  1 |  99.332     -0.731  1.018 |     52.164     84.533    -79.272  172.378 |
    2 |    21 -          g | 11 |   42   59   19   19 |  2  1 |  12.628     -0.514 -0.311 |     12.023     -3.862     -6.782   -0.000 |
    3 |  2212 -         p+ |  4 |   -1   -1    4    8 |  0  5 |   0.000  29256.000  0.000 |      0.000      0.000   6500.000    0.938 |
    4 |    82 -   rndmflav | 11 |    3    3   27   27 |  1  1 |   0.000     60.618 -0.000 |      0.000     -0.000   6405.248    0.931 |
    5 |    21 -          g | 11 |    3    3   28   29 |  1  2 |   0.957      6.455  0.459 |      0.858      0.424    304.341    0.000 |

With this PR, GenParticles2HepMCConverter searches for protons with large |eta| and |pz| to assign incident particles and the first vertices in the HepMC.

This will not affect the standard production.
NanoAOD was crashing to process herwig samples, and this PR solves the problem.

@intrepid42 @gpetruc

cmsbuild · 2017-11-17T13:22:43Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-17T13:25:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21349/2043

cmsbuild · 2017-11-17T13:26:11Z

A new Pull Request was created by @jhgoh (Junghwan John Goh) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

perrozzi · 2017-11-17T13:34:10Z

please test

cmsbuild · 2017-11-17T13:34:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24501/console Started: 2017/11/17 15:51

cmsbuild · 2017-11-17T17:00:13Z

+1
Tested at: 7f1c6e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24501/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4a2a37d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24501/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24501/git-merge-result

cmsbuild · 2017-11-17T17:00:17Z

Comparison job queued.

cmsbuild · 2017-11-17T18:03:01Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24501/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2833444
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2833265
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.66999999991 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

efeyazgan · 2017-11-17T18:16:36Z

+1

cmsbuild · 2017-11-27T14:35:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-27T14:42:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21349/2199

cmsbuild · 2017-11-27T14:42:36Z

Pull request #21349 was updated. @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please check and sign again.

jhgoh · 2017-11-27T14:50:30Z

Two additional changes:

Fix to run also on /GGToEE samples,
Address @davidlange6 's comment to use parentage information.
details in: crash in MergedGenParticleProducer cms-nanoAOD/cmssw#82

perrozzi · 2017-11-27T15:12:15Z

please test

cmsbuild · 2017-11-27T15:12:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24699/console Started: 2017/11/27 16:12

cmsbuild · 2017-11-27T17:02:33Z

+1
Tested at: ebd707d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24699/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a712be6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24699/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24699/git-merge-result

cmsbuild · 2017-11-27T17:02:36Z

Comparison job queued.

perrozzi · 2017-11-27T17:35:11Z

GeneratorInterface/RivetInterface/plugins/GenParticles2HepMCConverter.cc

@@ -109,27 +111,38 @@ void GenParticles2HepMCConverter::produce(edm::Event& event, const edm::EventSet

    hepmc_particles.push_back(hepmc_particle);
    genCandToHepMCMap[p] = hepmc_particle;
+
+    // Find incident proton pair
+    if ( p->mother() == nullptr and std::abs(p->eta()) > 5 and std::abs(p->pz()) > 1000 ) {


would it be worth putting a check on the pt fraction of the beam energy (if it is stored anywhere) ?
we have anyway 900 GeV data and Rivet plugins...

I'm ignorant - are there really particles with p->mother() == nullptr that are not the initial particles?

I think this is true for pruned/packed collections at MINIAOD level

yes some intermediate/final state particles loose mother during the MiniAOD pruning.

Thanks (though perhaps it should be possible to distinguish true motherless and pruned motherless in the future as to avoid the sort of fragile checks done here)

cmsbuild · 2017-11-27T17:50:46Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21349/24699/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2605338
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2605166
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.13000000005 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

perrozzi · 2017-11-27T22:13:21Z

+1

cmsbuild · 2017-11-27T22:13:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-11-30T14:52:17Z

+1

fix GenParticles2HepMCConverter to run on herwig sample

7f1c6e1

cmsbuild added this to the CMSSW_10_0_X milestone Nov 17, 2017

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels Nov 17, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 17, 2017

jhgoh force-pushed the FixToRunOnHerwigSample branch from 94ec44a to 7f1c6e1 Compare November 17, 2017 13:30

cmsbuild added tests-started and removed tests-pending labels Nov 17, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 17, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 17, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Nov 17, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2017

jhgoh mentioned this pull request Nov 27, 2017

94X backport: Fix GenParticles2HepMCConverter to run on herwig samples #21467

Merged

cmsbuild added tests-started and removed tests-pending labels Nov 27, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 27, 2017

perrozzi reviewed Nov 27, 2017

View reviewed changes

cmsbuild added comparison-available and removed comparison-pending labels Nov 27, 2017

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Nov 27, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 30, 2017

cmsbuild merged commit 876e7ad into cms-sw:master Nov 30, 2017

jhgoh deleted the FixToRunOnHerwigSample branch December 7, 2017 19:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GenParticles2HepMCConverter to run on herwig samples #21349

Fix GenParticles2HepMCConverter to run on herwig samples #21349

jhgoh commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

perrozzi commented Nov 17, 2017

cmsbuild commented Nov 17, 2017 •

edited

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

efeyazgan commented Nov 17, 2017

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

jhgoh commented Nov 27, 2017

perrozzi commented Nov 27, 2017

cmsbuild commented Nov 27, 2017 •

edited

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

perrozzi Nov 27, 2017

davidlange6 Nov 29, 2017

perrozzi Nov 30, 2017

jhgoh Nov 30, 2017

davidlange6 Nov 30, 2017

cmsbuild commented Nov 27, 2017

perrozzi commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

davidlange6 commented Nov 30, 2017

Fix GenParticles2HepMCConverter to run on herwig samples #21349

Fix GenParticles2HepMCConverter to run on herwig samples #21349

Conversation

jhgoh commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

perrozzi commented Nov 17, 2017

cmsbuild commented Nov 17, 2017 • edited

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

cmsbuild commented Nov 17, 2017

efeyazgan commented Nov 17, 2017

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

jhgoh commented Nov 27, 2017

perrozzi commented Nov 27, 2017

cmsbuild commented Nov 27, 2017 • edited

cmsbuild commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

perrozzi Nov 27, 2017

Choose a reason for hiding this comment

davidlange6 Nov 29, 2017

Choose a reason for hiding this comment

perrozzi Nov 30, 2017

Choose a reason for hiding this comment

jhgoh Nov 30, 2017

Choose a reason for hiding this comment

davidlange6 Nov 30, 2017

Choose a reason for hiding this comment

cmsbuild commented Nov 27, 2017

perrozzi commented Nov 27, 2017

cmsbuild commented Nov 27, 2017

davidlange6 commented Nov 30, 2017

cmsbuild commented Nov 17, 2017 •

edited

cmsbuild commented Nov 27, 2017 •

edited