Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed not so useful function BeamFitter::formatBTime() #2135

Merged
merged 1 commit into from Feb 6, 2014
Merged

Removed not so useful function BeamFitter::formatBTime() #2135

merged 1 commit into from Feb 6, 2014

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 22, 2014

which made "char ts[]" a static because otherwise the function returns the address of
a temporary. This function was only called by BeamFitter::updateBTime,
which was changed to produce the same results of formating two GMT times as strings
and putting the results in member variables.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X.

Removed not so useful function BeamFitter::formatBTime()

It involves the following packages:

RecoVertex/BeamSpotProducer

@nclopezo, @cmsbuild, @anton-a, @diguida, @rcastello, @slava77, @Degano, @thspeer can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

char ts[] a static because otherwise the function returns the address of
a function temporary. This function was only called by BeamFitter::updateBTime,
which was changed to produce the same results: format two GMT times as strings
and put the results in a member variable.
@cmsbuild
Copy link
Contributor

Pull request #2135 was updated. @nclopezo, @cmsbuild, @anton-a, @diguida, @rcastello, @slava77, @Degano, @thspeer can you please check and sign again.

@nclopezo
Copy link
Contributor

+1
The errors in the RelVals should be unrelated to this pr
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2135/15/summary.html

@rcastello
Copy link

+1

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@slava77
Copy link
Contributor

slava77 commented Feb 5, 2014

+1

based on 3d36851
code change OK
jenkins kind of ran (compiled OK, otherwise this part of the code is not run in regular tests)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2014

nclopezo added a commit that referenced this pull request Feb 6, 2014
…ove-static-ts

RecoVertex Fixes -- Removed not so useful function BeamFitter::formatBTime()
@nclopezo nclopezo merged commit 20f98d8 into cms-sw:CMSSW_7_1_X Feb 6, 2014
@gartung gartung deleted the RecoVertex-BeamSpotProducer-remove-static-ts branch February 6, 2014 16:41
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants