New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed not so useful function BeamFitter::formatBTime() #2135
Removed not so useful function BeamFitter::formatBTime() #2135
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_1_X. Removed not so useful function BeamFitter::formatBTime() It involves the following packages: RecoVertex/BeamSpotProducer @nclopezo, @cmsbuild, @anton-a, @diguida, @rcastello, @slava77, @Degano, @thspeer can you please review it and eventually sign? Thanks. |
char ts[] a static because otherwise the function returns the address of a function temporary. This function was only called by BeamFitter::updateBTime, which was changed to produce the same results: format two GMT times as strings and put the results in a member variable.
+1 |
+1 |
+1 based on 3d36851 |
…ove-static-ts RecoVertex Fixes -- Removed not so useful function BeamFitter::formatBTime()
which made "char ts[]" a static because otherwise the function returns the address of
a temporary. This function was only called by BeamFitter::updateBTime,
which was changed to produce the same results of formating two GMT times as strings
and putting the results in member variables.