Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr100x RPCTwinMux in L1TRawToDigi Sequence #21353

Merged
merged 1 commit into from Nov 18, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Nov 17, 2017

Fix: put dropped RPCTwinMux unpacker back into L1T unpacker sequence.

This unpacker is already in the L1REPACK:Full step relevant for HLT tests
and workflows. However, it was removed from the L1TRawToDigi sequence
unintentionally. It should be there.

@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Nov 17, 2017
@rekovic
Copy link
Contributor Author

rekovic commented Nov 17, 2017

please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@rekovic
Copy link
Contributor Author

rekovic commented Nov 17, 2017

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21353/2047

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24505/console Started: 2017/11/17 16:17

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/Configuration

@cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21353/24505/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2833444
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2833264
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.50000000003 KiB( 23 files compared)
  • Checked 111 log files, 8 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 53d7887 into cms-sw:master Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants