Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New macros in DPGAnalysis/SiStripTools and Validation/RecoVertex #2136

Merged
merged 12 commits into from Feb 6, 2014
Merged

New macros in DPGAnalysis/SiStripTools and Validation/RecoVertex #2136

merged 12 commits into from Feb 6, 2014

Conversation

venturia
Copy link
Contributor

No description provided.

@venturia
Added new macros. <export> tag removed from bin BuildFile
a3cd85a
@venturia
Changes to the occupancy plot macro to fulfill LE requests
2151736
@venturia
Added the possibility to correlate the multiplicity with the MC verte…
2b42acc 
…x z position

Conflicts:
	DPGAnalysis/SiStripTools/plugins/MultiplicityInvestigator.cc
@venturia
New cfg/cff added for the sistrip quality history
eef0953
@venturia
Added protection if the fill number is not available
019649b
@venturia
Added pvRecoSequence_cff.py which got lost between 53x and 62x
909a6fd
@venturia
Added a 2D histogram to monitor MC vertices vs BX number: 2nd step
6285d59
@venturia
Added a 2D histogram to monitor MC vertices vs BX number
e7f9fd8
@venturia
New root macros added
7e3d954
@venturia
New root macros added
da00b31
@venturia
Include needed commits of DPGAnalysis/SiStripTools into validation_re…
f51af0b 
…covertex-70x
@venturia
Merge branch 'dpganalysis_sistriptools-70x' into new_macros-70x
59a532d
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @venturia for CMSSW_7_1_X.

New macros in DPGAnalysis/SiStripTools and Validation/RecoVertex

It involves the following packages:

DPGAnalysis/SiStripTools
Validation/RecoVertex

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @vadler, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link

vadler commented Jan 23, 2014

+1

@nclopezo
Copy link
Contributor

+1
the errors in the RelVals should be unrelated to this pull request
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2136/24/summary.html

@deguio deguio mentioned this pull request Jan 28, 2014
Closed
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre3, CMSSW_7_1_0_pre2 Feb 5, 2014
@venturia
Copy link
Contributor Author

venturia commented Feb 5, 2014

@deguio,
does it mean that this pull request is going to approved by dqm soon?

@deguio
Copy link
Contributor

deguio commented Feb 5, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Feb 6, 2014
@ktf
Merge pull request #2136 from venturia/new_macros-70x
648904c 
Misc updates -- New macros in DPGAnalysis/SiStripTools and Validation/RecoVertex
@ktf ktf merged commit 648904c into cms-sw:CMSSW_7_1_X Feb 6, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
@venturia venturia mentioned this pull request Mar 5, 2014
Merged
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
nclopezo added a commit that referenced this pull request Mar 14, 2014
@nclopezo
Merge pull request #2724 from venturia/dpganalysis_sistriptools-70x
d031b8e 
Backport of #2723 and (part of) #2136 for April global run
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
@aledegano
Merge pull request cms-sw#2136 from degano/openloops_80XStable
eb24842 
Upgrade Openloops to 1.2.4 with CMS patches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_1_0_pre5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@venturia @cmsbuild @vadler @nclopezo @deguio @ktf