Include TrackCandidateCollection in TrackCandidateSeedAssociation.h #21408

Teemperor · 2017-11-21T14:25:17Z

We use TrackCandidateCollection in this header, but only include
TrackCandidate.h. This patch fixes the include to make this header
parsable on its own.

We use TrackCandidateCollection in this header, but only include TrackCandidate.h. This patch fixes the include to make this header parsable on its own.

Teemperor · 2017-11-21T14:25:22Z

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

cmsbuild · 2017-11-21T14:25:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-21T14:29:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21408/2115

cmsbuild · 2017-11-21T14:31:50Z

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

DataFormats/TrackCandidate

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @gpetruc, @ebrondol, @rovere, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

makortel · 2017-11-21T14:40:48Z

I don't see any users in CMSSW for any of the typedef's (with git grep). Maybe we could just remove the header and the entries from classes.h and classes_def.xml? @VinInn

VinInn · 2017-11-21T14:42:26Z

+1
I am also proceeding to a cleanup for 10.0.X

makortel · 2017-11-21T14:46:48Z

@Teemperor Can you do the cleanup?

davidlange6 · 2017-11-21T15:42:52Z

please test

cmsbuild · 2017-11-21T15:44:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24577/console Started: 2017/11/21 16:45

cmsbuild · 2017-11-21T20:45:05Z

-1

Tested at: 2c0944e

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test runtestTqafTopEventProducers had ERRORS
---> test runtestTqafTopEventSelection had ERRORS
---> test runtestTqafExamples had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
893188d
0707ff5
bbddd85
ed2b195
12605de
3441962
c792deb
8d25c3d
84e2869
54ee550
3468977
eeb8263
32307fd
34b0dcf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/git-merge-result

cmsbuild · 2017-11-21T20:45:07Z

Comparison job queued.

cmsbuild · 2017-11-21T23:09:12Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24577/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3523 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2746803
DQMHistoTests: Total failures: 9379
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2737247
DQMHistoTests: Total skipped: 177
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.05000000008 KiB( 22 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

perrotta · 2017-11-22T15:24:40Z

please test with #21186
(Trying to see if less merge commits are merged together this time, and we can get rid as such to the differences seen by jenkins, which are not expected due to this PR alone)

cmsbuild · 2017-11-22T15:25:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24624/console Started: 2017/11/22 16:34

cmsbuild · 2017-11-22T17:43:42Z

+1
Tested at: 2c0944e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24624/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
eeb5cf4
5780cd4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24624/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24624/git-merge-result

cmsbuild · 2017-11-22T17:43:45Z

Comparison job queued.

cmsbuild · 2017-11-22T19:14:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21408/24624/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2833444
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2833265
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.23999999992 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

slava77 · 2017-11-22T22:38:30Z

+1

for #21408 2c0944e

implemented as described; this is technical outside of the scope of getting the header parsable on its own
jenkins tests pass

cmsbuild · 2017-11-22T22:38:49Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-11-23T07:32:51Z

+1

VinInn · 2017-11-23T09:40:34Z

where this TrackCandidateSeedAssociation is supposed to be used????
https://cmssdt.cern.ch/dxr/CMSSW/search?q=TrackCandidateSeedAssociation&case=true&redirect=true
I will rm it for good...

makortel · 2017-11-23T09:45:14Z

It's not, hence I suggested the cleanup above (#21408 (comment)).

VinInn · 2017-11-23T09:46:41Z

I will schedule it for my cleanup campaign...

Include TrackCandidateCollection in TrackCandidateSeedAssociation.h

2c0944e

We use TrackCandidateCollection in this header, but only include TrackCandidate.h. This patch fixes the include to make this header parsable on its own.

cmsbuild added this to the CMSSW_10_0_X milestone Nov 21, 2017

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 21, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 21, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 21, 2017

cmsbuild added tests-rejected and removed tests-started labels Nov 21, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 21, 2017

cmsbuild removed the comparison-available label Nov 22, 2017

cmsbuild added comparison-pending tests-pending and removed tests-rejected labels Nov 22, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 22, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 22, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 22, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 22, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 23, 2017

cmsbuild merged commit f36b966 into cms-sw:master Nov 23, 2017

Teemperor deleted the TrackCandidate branch December 19, 2017 08:47

Teemperor restored the TrackCandidate branch December 19, 2017 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include TrackCandidateCollection in TrackCandidateSeedAssociation.h #21408

Include TrackCandidateCollection in TrackCandidateSeedAssociation.h #21408

Teemperor commented Nov 21, 2017

Teemperor commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

makortel commented Nov 21, 2017

VinInn commented Nov 21, 2017

makortel commented Nov 21, 2017

davidlange6 commented Nov 21, 2017

cmsbuild commented Nov 21, 2017 •

edited

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

perrotta commented Nov 22, 2017

cmsbuild commented Nov 22, 2017 •

edited

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

slava77 commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

davidlange6 commented Nov 23, 2017

VinInn commented Nov 23, 2017

makortel commented Nov 23, 2017

VinInn commented Nov 23, 2017

Include TrackCandidateCollection in TrackCandidateSeedAssociation.h #21408

Include TrackCandidateCollection in TrackCandidateSeedAssociation.h #21408

Conversation

Teemperor commented Nov 21, 2017

Teemperor commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

makortel commented Nov 21, 2017

VinInn commented Nov 21, 2017

makortel commented Nov 21, 2017

davidlange6 commented Nov 21, 2017

cmsbuild commented Nov 21, 2017 • edited

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

cmsbuild commented Nov 21, 2017

perrotta commented Nov 22, 2017

cmsbuild commented Nov 22, 2017 • edited

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

slava77 commented Nov 22, 2017

cmsbuild commented Nov 22, 2017

davidlange6 commented Nov 23, 2017

VinInn commented Nov 23, 2017

makortel commented Nov 23, 2017

VinInn commented Nov 23, 2017

cmsbuild commented Nov 21, 2017 •

edited

cmsbuild commented Nov 22, 2017 •

edited