New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored HcalRecHitFwd.h to HcalRecHitDefs.h #21415
Conversation
As discussed in PR cms-sw#18805, the *Fwd.h files aren't working with forward declarations (due to `Ref` needing a definition). This PR brings the same change to the HcalRecHitFwd.h header.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: DataFormats/CastorReco @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: Comparison Summary:
|
please test with #21186 |
The tests are being triggered in jenkins. |
the occasional log error differences seem to be a feature these days..
… On Nov 22, 2017, at 4:29 PM, perrotta ***@***.***> wrote:
please test with #21186
(Trying to see if less merge commits are merged together this time, and we can get rid as such to the differences seen by jenkins, which are not expected due to this PR alone)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
As discussed in PR #18805, the *Fwd.h files aren't working with
forward declarations (due to
Ref
needing a definition). ThisPR brings the same change to the HcalRecHitFwd.h header.