Clean SeedClusterRemover

[VinInn]

remove obsolete "waste cluster" option.

purely technical, regressions not expected

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21463/2193

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for master.

It involves the following packages:

RecoLocalTracker/SubCollectionProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @nickmccoll, @jlagram, @gpetruc, @OlivierBondu, @mmusich, @threus, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[VinInn]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24684/console Started: 2017/11/25 16:07

[cmsbuild]

+1
Tested at: 8c5f989
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21463/24684/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2f0caec
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21463/24684/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21463/24684/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21463/24684/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.58000000018 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[VinInn]

have not managed to identify the "2 differences"....

[davidlange6]

Likely a log error or warning count somewhere.. Cheers, David On 26 Nov 2017, at 09:54, Vincenzo Innocente <notifications@github.com<mailto:notifications@github.com>> wrote: have not managed to identify the "2 differences".... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#21463 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzbt7XwXwwm6fUOl3sFD6bDzi2NSks5s6Sb4gaJpZM4Qqc2o>.

[perrotta]

+1

• Just clean up in the code
• No regression observed: the extra logError in 25202 relates to the inclusion of files for the mixing module

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1