Bugfix new CaloLayer1 unpacker

[nsmith-]

Fixes #21067

l1t::Block::payload() returns a copy of internal std::vector
which we grabbed a bare pointer to, but then it is destructed since it
is an rvalue, so the things we do with that pointer are rather naughty.

Fixed by returning const reference, as all access patterns are read-only
anyway. Propagated const-ness to bare pointer in the UCTCTP7RawData
utility.

p.s. introduced in #20914, backport to 94x necessary I suppose?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21486/2244

[cmsbuild]

A new Pull Request was created by @nsmith- (Nicholas Smith) for master.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[thomreis]

please test

Let's see if this works.
Are other unpackers also affected by this?

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24759/console Started: 2017/11/30 09:25

[cmsbuild]

+1
Tested at: c7e2b5a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21486/24759/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
8eb7f2c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21486/24759/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21486/24759/git-merge-result

[cmsbuild]

Comparison job queued.

[rekovic]

+1

[rekovic]

@nsmith-
Thanks.
A backport of #20914 plus the fixes from this PR, all together would comprise one backport PR.

[nsmith-]

@thomreis only in that they will be faster now.
I will double check if valgrind complains about any other bits in the unpacker, but I think it is unlikely.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[nsmith-]

Follow-up: no other invalid reads in

cmsDriver.py digi -s RAW2DIGI --eventcontent=FEVTDEBUGHLT --filein=/store/data/Run2017G/HLTPhysics/RAW/v1/000/306/584/00000/1277E19C-D2C8-E711-AA4F-02163E01A5C7.root --data -n 10 --conditions=auto:run2_data --no_exec
time valgrind --tool=memcheck --suppressions=$CMSSW_RELEASE_BASE/src/Utilities/ReleaseScripts/data/cms-valgrind-memcheck.supp --num-callers=20 --xml=yes --xml-file=valgrind.xml cmsRun digi_RAW2DIGI.py

although there seem to be plenty of other leaks, valgrind.xml is 12Mb!

[nsmith-]

@rekovic actually #20914 is in 940, unless you mean a backport to <94X then I only need to port this PR to 940

$ git tag --contains 85a88428d46118e952a07217f70ef8dedd20d187 |grep -v "_X_"
CMSSW_10_0_0_pre1
CMSSW_9_4_0
CMSSW_9_4_0_patch1
CMSSW_9_4_0_pre3

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21486/24759/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2788080
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787901
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.58000000014 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[davidlange6]

+1