Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing include to SiStripPayloadInspectorHelper.h #21522

Merged

Conversation

Teemperor
Copy link
Contributor

We reference SiStripDetSummary::Values in this header, so
we also need to include the associated header to make this
file parsable on its own.

We reference SiStripDetSummary::Values in this header, so
we also need to include the associated header to make this
file parsable on its own.
@Teemperor
Copy link
Contributor Author

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21522/2283

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 73b65b2 into cms-sw:master Dec 7, 2017
@Teemperor Teemperor deleted the IncludeSistrippayloadinspectorhelperh branch December 19, 2017 08:47
@Teemperor Teemperor restored the IncludeSistrippayloadinspectorhelperh branch December 19, 2017 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants