New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Sourcevariable.h in SourceVariableSet.h #21532
Include Sourcevariable.h in SourceVariableSet.h #21532
Conversation
The existing forward decl is not enough for this header to be parsed as we actually require the definition of SourceVariable in this line: ```C++ { return var.var->getName() < name; } ^ ```
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: PhysicsTools/MVATrainer @cmsbuild, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
merge |
The existing forward decl is not enough for this header to be
parsed as we actually require the definition of SourceVariable
in this line: