Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting HO SIM to Run I baseline option #2156

Merged
merged 1 commit into from Feb 2, 2014

Conversation

abdoulline
Copy link

NB: to be used with Run I HO conditions.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline for CMSSW_7_0_X.

Reverting HO SIM to Run I baseline option

It involves the following packages:

SimCalorimetry/HcalSimProducers

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

Confused... what is this really doing. Do we need to add this to the postls1 customize list?

@slava77
Copy link
Contributor

slava77 commented Jan 24, 2014

Current release defaults should have Run1 configuration.
This PR brings HO to the Run1 setup.

The following will need to be added to post-LS1 customization to make configs for post-LS1

process.mix.digitizers.hcal.ho.photoelectronsToAnalog = cms.vdouble([4.0]*16)
process.mix.digitizers.hcal.ho.siPMCode = cms.int32(1)
process.mix.digitizers.hcal.ho.pixels = cms.int32(2500)
process.mix.digitizers.hcal.ho.doSiPMSmearing = cms.bool(False)

@abdoulline
Copy link
Author

If you mean 620_SLHC6 HCalCustoms.py (HcalPhase0)?

It doesn't need post-LS1 HO customization, as it's by default set in
CMSSW_6_2_0_SLHC6/src/SimCalorimetry/HcalSimProducers/python/hcalSimParameters_cfi.py
and "just" needs post-LS1 (HO) conditions in GT

On Fri, 24 Jan 2014, davidlange6 wrote:

Confused... what is this really doing. Do we need to add this to the postls1 customize list?


Reply to this email directly or view it onGitHub.[5010650__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjA4MzY3NywiZGF0YSI6eyJpZC
I6MjQxNzM3NDF9fQ==--88119f45fa6b2d917ee4e5f2384eba6b1f44224f.gif]

@davidlange6
Copy link
Contributor

ok - can we add that customize to the same pull request as to make sure we don't make a bigger mess…

On Jan 24, 2014, at 9:18 AM, slava77 notifications@github.com
wrote:

Current release defaults should have Run1 configuration.
This PR brings HO to the Run1 setup.

The following will need to be added to post-LS1 customization to make configs for post-LS1

process.mix.digitizers.hcal.ho.photoelectronsToAnalog = cms.vdouble([4.0]*16)
process.mix.digitizers.hcal.ho.siPMCode = cms.int32(1)
process.mix.digitizers.hcal.ho.pixels = cms.int32(2500)
process.mix.digitizers.hcal.ho.doSiPMSmearing = cms.bool(False)


Reply to this email directly or view it on GitHub.

@davidlange6
Copy link
Contributor

and what about 62x?

@abdoulline
Copy link
Author

62X (e.g. 6_2_6) uses by default an old "Run I" HO configuration
and has to use Run I conditions (In DIGI-RECO), and those in "startup" by
default in
/afs/cern.ch/cms/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_6/src/Configuration/AlCa/python/autoCond.py
PRE_ST62_V8::All
do correspond to the config.

On Fri, 24 Jan 2014, davidlange6 wrote:

and what about 62x?


Reply to this email directly or view it onGitHub.[5010650__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcwNjA4NDgwMywiZGF0YSI6eyJpZC
I6MjQxNzM3NDF9fQ==--081861acca13fb8aadc4a6a1df472c58768cec3b.gif]

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jan 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

do we have the needed customize function to switch back and forth integrated? (seems not)

@davidlange6
Copy link
Contributor

+1
(customize function is in different PR now)

ktf added a commit that referenced this pull request Feb 2, 2014
Sim fixes -- Reverting HO SIM  to Run I baseline option
@ktf ktf merged commit a78d435 into cms-sw:CMSSW_7_0_X Feb 2, 2014
@abdoulline abdoulline deleted the HO_SIM_reverting_to_RunI branch October 22, 2014 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants