New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverting HO SIM to Run I baseline option #2156
Conversation
A new Pull Request was created by @abdoulline for CMSSW_7_0_X. Reverting HO SIM to Run I baseline option It involves the following packages: SimCalorimetry/HcalSimProducers @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
Confused... what is this really doing. Do we need to add this to the postls1 customize list? |
Current release defaults should have Run1 configuration. The following will need to be added to post-LS1 customization to make configs for post-LS1 process.mix.digitizers.hcal.ho.photoelectronsToAnalog = cms.vdouble([4.0]*16)
process.mix.digitizers.hcal.ho.siPMCode = cms.int32(1)
process.mix.digitizers.hcal.ho.pixels = cms.int32(2500)
process.mix.digitizers.hcal.ho.doSiPMSmearing = cms.bool(False) |
It doesn't need post-LS1 HO customization, as it's by default set in On Fri, 24 Jan 2014, davidlange6 wrote:
|
ok - can we add that customize to the same pull request as to make sure we don't make a bigger mess… On Jan 24, 2014, at 9:18 AM, slava77 notifications@github.com
|
and what about 62x? |
62X (e.g. 6_2_6) uses by default an old "Run I" HO configuration On Fri, 24 Jan 2014, davidlange6 wrote:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @ktf can you please take care of it? |
do we have the needed customize function to switch back and forth integrated? (seems not) |
+1 |
Sim fixes -- Reverting HO SIM to Run I baseline option
NB: to be used with Run I HO conditions.