Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop dependency on curl/types.h which we were picking up from system #2157

Merged
merged 1 commit into from
Jan 24, 2014
Merged

drop dependency on curl/types.h which we were picking up from system #2157

merged 1 commit into from
Jan 24, 2014

Conversation

smuzaffar
Copy link
Contributor

DQMServices/XdaqCollector/interface/XmasToDQM.h includes curl/types.h which is

  • empty file on slc5
  • does not exist for slc6 curl distribution of cms
    53X slc6 IBs/releases were working as this file was picked up from system curl. dropping this should not harm as this file is empty anyway.

@smuzaffar
Copy link
Contributor Author

+tested

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_5_3_X.

drop dependency on curl/types.h which we were picking up from system

It involves the following packages:

DQMServices/XdaqCollector

@danduggan, @ojeda, @rovere, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor Author

by the way, compilation of DQMServices/XdaqCollector fails on those slc6 system where curl/types.h header is not available.

@smuzaffar
Copy link
Contributor Author

@davidlange6 , I am bypassing all signatures for this and merging it for 53X so that next 53X slc6 IB build without errors.

smuzaffar added a commit that referenced this pull request Jan 24, 2014
drop dependency on curl/types.h which we were picking up from system
@smuzaffar smuzaffar merged commit 1d18daf into cms-sw:CMSSW_5_3_X Jan 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants