New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing includes to HLTRechitInRegionsProducer.h #21581
Added missing includes to HLTRechitInRegionsProducer.h #21581
Conversation
We use EcalEtaPhiRegion and EcalRecHitCollection in this header, so we also need to include EcalEtaPhiRegion.h and EcalRecHitCollections.h to make this file parsable on its own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: RecoEgamma/EgammaHLTProducers @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
@@ -16,6 +16,9 @@ | |||
#include "DataFormats/RecoCandidate/interface/RecoCandidate.h" | |||
#include "DataFormats/RecoCandidate/interface/RecoChargedCandidate.h" | |||
|
|||
#include "RecoEcal/EgammaCoreTools/interface/EcalEtaPhiRegion.h" | |||
#include "DataFormats/EcalRecHit/interface/EcalRecHitCollections.h" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you sort the #includes alphabetically ?
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
Comparison is ready Comparison Summary:
|
merge |
We use EcalEtaPhiRegion and EcalRecHitCollection in this header,
so we also need to include EcalEtaPhiRegion.h and EcalRecHitCollections.h
to make this file parsable on its own.