New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added include for cmath to TopQuarkAnalysis/TopObjectResolutions #21601
Added include for cmath to TopQuarkAnalysis/TopObjectResolutions #21601
Conversation
We use fabs and other functions from cmath in these headers, but we don't actually include cmath. This patch adds this include so that these headers are parsable on their own.
Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile. |
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @Teemperor (Raphael Isemann) for master. It involves the following packages: TopQuarkAnalysis/TopObjectResolutions @cmsbuild, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
merge |
Comparison is ready Comparison Summary:
|
We use fabs and other functions from cmath in these headers, but
we don't actually include cmath. This patch adds this include
so that these headers are parsable on their own.