Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of destructor calls #21634

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Dr15Jones
Copy link
Contributor

The deletion of 'this' via the shared_ptr 'self' must happen after the destructor for outstanding_guard is called.

The deletion of 'this' via the shared_ptr 'self' must happen after the destructor for outstanding_guard is called.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21634/2405

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Utilities/XrdAdaptor

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24918/console Started: 2017/12/02 15:18

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@Dr15Jones
Copy link
Contributor Author

@bbockelm thought you'd be interested.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21634/24918/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21634/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+NANOMERGE

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835085
  • DQMHistoTests: Total failures: 21
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2834886
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.09999999988 KiB( 23 files compared)
  • Checked 114 log files, 10 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9f5ccfe into cms-sw:master Dec 3, 2017
@Dr15Jones Dr15Jones deleted the fixHandleResponseWithHosts branch December 4, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants