Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed calls to TH1::SetBit since they are not intended for users #21635

Merged
merged 1 commit into from Dec 3, 2017

Conversation

Dr15Jones
Copy link
Contributor

This code broke under ROOT 6.0.12. The ROOT team says that using SetBit
for user data should not be done since the meaning of those bits
is reserved for ROOT's own internal usage.

This code broke under ROOT 6.0.12. The ROOT team says that using SetBit
for user data should not be done since the meaning of those bits
is reserved for ROOT's own internal usage.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

This addresses issue #21423

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

@davidlange6 this should avoid the 400+ failures in the ROOT_6 IBs.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21635/2406

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24919/console Started: 2017/12/02 15:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/EcalCommon

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21635/24919/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21635/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+NANOMERGE

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835085
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2834906
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.55999999998 KiB( 23 files compared)
  • Checked 114 log files, 10 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit f8ccf77 into cms-sw:master Dec 3, 2017
@Dr15Jones Dr15Jones deleted the root6_0_12_fix_MESetEcal branch December 4, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants