New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed calls to TH1::SetBit since they are not intended for users #21635
Conversation
This code broke under ROOT 6.0.12. The ROOT team says that using SetBit for user data should not be done since the meaning of those bits is reserved for ROOT's own internal usage.
The code-checks are being triggered in jenkins. |
This addresses issue #21423 |
please test |
@davidlange6 this should avoid the 400+ failures in the ROOT_6 IBs. |
+code-checks |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/EcalCommon @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
merge |
This code broke under ROOT 6.0.12. The ROOT team says that using SetBit
for user data should not be done since the meaning of those bits
is reserved for ROOT's own internal usage.