Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmsDriver exception message when --conditions is not given #21648

Merged
merged 1 commit into from Dec 6, 2017

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 5, 2017

Minimal fix to resolve #12708. The autoCond.autoCond[k] can be a tuple, so easiest was just to convert it to a string for concatenation.

Tested in 10_0_0_pre1, no changes expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21648/2439

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 5, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21648/24951/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21648/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2835085
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2834906
  • DQMHistoTests: Total skipped: 178
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.59999999993 KiB( 23 files compared)
  • Checked 113 log files, 9 edm output root files, 27 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit d4a6c2d into cms-sw:master Dec 6, 2017
@makortel makortel deleted the fixCmsdriverConditions branch February 12, 2018 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmsDriver does not give proper error message for missing --conditions option
3 participants