Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

53 x lhe scripts #2177

Merged
merged 3 commits into from
Jan 30, 2014
Merged

53 x lhe scripts #2177

merged 3 commits into from
Jan 30, 2014

Conversation

vciulli
Copy link
Contributor

@vciulli vciulli commented Jan 27, 2014

updates scripts to handle lhe files and to run powheg

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vciulli (Vitaliano Ciulli) for CMSSW_5_3_X.

53 x lhe scripts

It involves the following packages:

GeneratorInterface/LHEInterface

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@smuzaffar you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #2177 was updated. @vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please check and sign again.

@vciulli
Copy link
Contributor Author

vciulli commented Jan 27, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_5_3_X IBs unless changes or unless it breaks tests. @smuzaffar can you please take care of it?

@davidlange6
Copy link
Contributor

why add scripts to the data directory?

@vciulli
Copy link
Contributor Author

vciulli commented Jan 28, 2014

Good point.
I added it there because all scripts that are called by ExternalLHEProducer are in this directory, but I don't know why. Most probably for some historical reason (maybe originally there where also tar balls).
However changing the location breaks configurations used for the production.
We will add this point in the todo list but meanwhile it is important to have this pull in for the GEN-SIM production.

@davidlange6
Copy link
Contributor

+1

@smuzaffar
Copy link
Contributor

+tested

smuzaffar added a commit that referenced this pull request Jan 30, 2014
@smuzaffar smuzaffar merged commit ec7a477 into cms-sw:CMSSW_5_3_X Jan 30, 2014
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data for L1Trigger/L1TGlobal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants