New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPPFDigis dataformat and RPC unpacker #21802
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21802/2787 |
A new Pull Request was created by @jhgoh (Junghwan John Goh) for master. It involves the following packages: CondTools/RPC @perrotta, @cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @thomreis, @slava77, @ggovi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 2601ab4 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpackerFactory.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCRawToDigi.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCReadOutMappingWithFastSearch.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc: In member function 'virtual void RPCTwinMuxRawToDigi::produce(edm::Event&, const edm::EventSetup&)': /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:88:27: error: 'fed_event_' is not a member of 'RPCAMCLinkCounters' counters->add(RPCAMCLinkCounters::fed_event_, RPCAMCLink(fed, RPCAMCLink::wildcard_)); ^~~~~~~~~~~~~~~~~~ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:136:35: error: 'fed_trailer_crc_mismatch_' is not a member of 'RPCAMCLinkCounters' counters->add(RPCAMCLinkCounters::fed_trailer_crc_mismatch_, RPCAMCLink(fed, RPCAMCLink::wildcard_)); ^~~~~~~~~~~~~~~~~~
I found a compilation error while trying to compile with clang: >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpackerFactory.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCRawToDigi.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCReadOutMappingWithFastSearch.cc >> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/SealModule.cc /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:88:47: error: no member named 'fed_event_' in 'RPCAMCLinkCounters' counters->add(RPCAMCLinkCounters::fed_event_, RPCAMCLink(fed, RPCAMCLink::wildcard_)); ~~~~~~~~~~~~~~~~~~~~^ /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:136:55: error: no member named 'fed_trailer_crc_mismatch_' in 'RPCAMCLinkCounters' counters->add(RPCAMCLinkCounters::fed_trailer_crc_mismatch_, RPCAMCLink(fed, RPCAMCLink::wildcard_)); ~~~~~~~~~~~~~~~~~~~~^ The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
fixed build error |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1
|
@perrotta thank you for all the reviews. we can continue to the next stage based on this PR. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR adds new CPPFDigis dataformat and RPC unpacker with related codes,
most contributions by @abrinke1 for the CPPFDigis and @fthyssen for the RPC unpacker part.
We would like to include the new CPPFDigis but not enable by default - as the first step of RPC-CPPF integration and move to next steps.
Presentation at RECO/AT 2018.01.13
@abrinke1 @rekovic @mileva