Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoCond: update the "hltonline" global tag to the latest available (GR_H_V33) #2181

Closed
wants to merge 1 commit into from

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 27, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_0_X.

autoCond: update the "hltonline" global tag to the latest available (GR_H_V33)

It involves the following packages:

Configuration/AlCa

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2181/2162/summary.html

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 28, 2014

looking into it ...

@cmsbuild
Copy link
Contributor

Pull request #2181 was updated. @cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 28, 2014

OK, with the correct connection srtring it passes runTheMatrix.py -l

$ cat runall-report-step123-.log
4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Tue Jan 28 10:33:46 2014-date Tue Jan 28 10:28:49 2014; exit: 0 0 0 0 0
4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Jan 28 10:51:43 2014-date Tue Jan 28 10:28:51 2014; exit: 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED - time date Tue Jan 28 10:33:12 2014-date Tue Jan 28 10:28:52 2014; exit: 0 0
8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Tue Jan 28 10:35:42 2014-date Tue Jan 28 10:28:55 2014; exit: 0 0 0 0 0
25.0_TTbar+TTbar+DIGI+RECO+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Tue Jan 28 10:49:18 2014-date Tue Jan 28 10:28:56 2014; exit: 0 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Tue Jan 28 10:38:57 2014-date Tue Jan 28 10:28:57 2014; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Tue Jan 28 10:36:02 2014-date Tue Jan 28 10:28:58 2014; exit: 0 0 0 0
7 7 6 6 4 tests passed, 0 0 0 0 0 failed

The lesson is, do not test things only online...

@ktf
Copy link
Contributor

ktf commented Jan 28, 2014

Can you please rebase -i and squash the commits?

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 28, 2014

All of them since the beginning of recorded human history, or just since CMSSW_7_0_0_pre12 ?

@ktf
Copy link
Contributor

ktf commented Jan 28, 2014

the two in this pull request… Ah, git rebase -i <your-fork-point> might be what I meant...

@fwyzard
Copy link
Contributor Author

fwyzard commented Jan 28, 2014

Done, though I prefer not to rewrite the git history after publishing a pull request, unless it needs heavy development...

@cmsbuild
Copy link
Contributor

Pull request #2181 was updated. @cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please check and sign again.

@ktf
Copy link
Contributor

ktf commented Jan 28, 2014

IMHO rewriting history is good for the fix-up cases like this one, since the second commit is really something which should have not been there is the first place. If it does not retrigger a full chain of validation, I think it's ok to do so.

@Degano can you please retest?

@cmsbuild
Copy link
Contributor

-1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2181/3/summary.html

@Martin-Grunewald
Copy link
Contributor

This is now included in and fixed by PR #2110 .

@cmsbuild
Copy link
Contributor

@fwyzard fwyzard closed this Feb 13, 2014
@fwyzard fwyzard deleted the update_autoCond_HLT_70X branch February 13, 2014 22:12
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Advance data for Fireworks/Geometry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants