Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fragment for Z2starLEP tune #2199

Merged
1 commit merged into from Jan 30, 2014
Merged

Conversation

vciulli
Copy link
Contributor

@vciulli vciulli commented Jan 28, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vciulli (Vitaliano Ciulli) for CMSSW_6_2_X.

added fragment for Z2starLEP tune

It involves the following packages:

Configuration/Generator

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vciulli
Copy link
Contributor Author

vciulli commented Jan 28, 2014

+1

On 28 Jan 2014, at 14:23, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @vciulli (Vitaliano Ciulli) for CMSSW_6_2_X.

added fragment for Z2starLEP tune

It involves the following packages:

Configuration/Generator

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes or unless it breaks tests. @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

SyntaxError: ('invalid syntax', ('src/HLTrigger/Configuration/python/HLT_8E33v2_cff.py', 1, 2, '<<<<<<< HEAD\n'))

gmake[1]: **\* [CompilePython] Error 1
gmake[1]: Leaving directory `/build/cmsbuild/jenkins-workarea/workspace/Pull-Request-Integration-6_2_X_SLHC-slc5/ARCHITECTURE/slc5_amd64_gcc472/CMSSW_6_2_X_SLHC_2014-01-28-0200'
gmake: **\* [src] Error 2
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2199/1/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (but tests are reportedly failing). @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X IBs unless changes (tests are also fine). @Degano can you please take care of it?

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1
(I don't see what the error messages have to do with this pull request - they can not be related)

@ktf
Copy link
Contributor

ktf commented Jan 30, 2014

Indeed, cmsbuild tested it again and everything was fine.

ghost pushed a commit that referenced this pull request Jan 30, 2014
Generator -- added fragment for Z2starLEP tune
@ghost ghost merged commit 7ed66b5 into cms-sw:CMSSW_6_2_X Jan 30, 2014
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants