stack trace on SIGABRT to catch assertion failures #22097
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22097/3226 |
|
A new Pull Request was created by @dan131riley (Dan Riley) for master. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
@fabiocos it would be very helpful to get this is as soon as possible in order to track down several failures that are occurring. |
|
+1 |
This PR adds SIGABRT to the list of signals for which we initiate a stack trace. This is motivated by recent assertion failures in ROOT 6.12 builds that may be due to thread-safety issues. Since the InitRootHandlers module itself calls abort() to handle some failure modes, the modifications are careful to reset the SIGABRT handler to SIG_DFL at the appropriate places.