Add CTPPS record

[mommsen]

Implement a new record for CTPPS status information. This information becomes available with version 2 of the softFED 1022 record.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22152/3286

[cmsbuild]

A new Pull Request was created by @mommsen (Remi Mommsen) for master.

It involves the following packages:

DataFormats/OnlineMetaData
EventFilter/OnlineMetaDataRawToDigi

@mommsen, @perrotta, @cmsbuild, @emeschi, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mommsen]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25960/console Started: 2018/02/07 21:47

[slava77]

this array could be a static const
same for the statusNames_

[cmsbuild]

+1
Tested at: c6b64f8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22152/25960/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22152/25960/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22152/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2466491
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2466321
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.06999999999 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[cmsbuild]

Pull request #22152 was updated. @perrotta, @emeschi, @cmsbuild, @franzoni, @slava77, @mommsen, @fabiocos, @davidlange6 can you please check and sign again.

[mommsen]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26350/console Started: 2018/02/27 18:39

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22152/3592

[cmsbuild]

+1
Tested at: fdd5f2e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22152/26350/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22152/26350/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22152/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2499373
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2499195
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.15000000004 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #22152 d83d12b

• changes are in line with the PR description and the follow up review:
  • introduced onlineMetaDataDigis producer in the standard workflows (enabled unconditionally)
  • added CTPPS status record
  • made all products produced by onlineMetaDataDigis persisted in standard event contents (pp, HI, and cosmics) in FEVT, RECO, and AOD
  • fixed up the cosmics event content to also keep the TCDS output
• jenkins tests pass and comparisons with the baseline show no differences (the changes affect only the newly added data products). The PR QA checks confirm that the new products appear in the outputs:

ROOTFileChecks
Change in products found in 25202.0_TTbar_13*/step3.root
    Product added OnlineLuminosityRecord_onlineMetaDataDigis__RECO.
    Product added recoBeamSpot_onlineMetaDataDigis__RECO.
    Product added CTPPSRecord_onlineMetaDataDigis__RECO.
    Product added DCSRecord_onlineMetaDataDigis__RECO.

[mommsen]

+1

[fabiocos]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1